Skip to content

pylock: validate name/version consistency in file names#1114

Merged
brettcannon merged 2 commits intopypa:mainfrom
sbidoul:more-pylock-package-filename-validation-sbi
Mar 24, 2026
Merged

pylock: validate name/version consistency in file names#1114
brettcannon merged 2 commits intopypa:mainfrom
sbidoul:more-pylock-package-filename-validation-sbi

Conversation

@sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 11, 2026

This validates that package.wheels[].filename and package.sdist.filename are consistent with package.name and package.version.

@brettcannon

@henryiii
Copy link
Contributor

Is this a followup to #1095 (comment)?

@sbidoul
Copy link
Member Author

sbidoul commented Mar 11, 2026

Is this a followup to #1095 (comment)?

No, this is rather a few additional consistency checks that I think are worthwhile.

I'll prepare a separate PR for #1095 (comment).

@sbidoul
Copy link
Member Author

sbidoul commented Mar 11, 2026

I'll prepare a separate PR for #1095 (comment).

#1117

@brettcannon
Copy link
Member

@sbidoul there's now merge conflicts due to #1117 getting merged.

@sbidoul sbidoul force-pushed the more-pylock-package-filename-validation-sbi branch from 78d2db9 to 3a17ea9 Compare March 24, 2026 12:43
@brettcannon brettcannon merged commit f0469a6 into pypa:main Mar 24, 2026
56 checks passed
@sbidoul sbidoul deleted the more-pylock-package-filename-validation-sbi branch March 24, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants